-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libsigcpp] Fix usage in static build #18944
[libsigcpp] Fix usage in static build #18944
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! This LGTM once my suggestion is applied.
The failures caused by libgo on x64-windows-static:
Will be fixed via PR #19037 The failures caused by
May be fixed via PR #19039 The failures caused by
Seems to be fixed via PR #18994 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Describe the pull request
What does your PR fix?
Fixes [libsigcpp-3] build failure #18808
define
SIGC_DLL
as1
only in dynamic build.Note: No feature needs to test.